Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse pose graph is a poor name #646

Closed
wohe opened this issue Nov 9, 2017 · 3 comments
Closed

Sparse pose graph is a poor name #646

wohe opened this issue Nov 9, 2017 · 3 comments
Assignees
Labels

Comments

@wohe
Copy link
Member

wohe commented Nov 9, 2017

The name 'sparse pose graph' is a poor choice since 'pose graph' conveys all the important information and the word 'sparse' is mostly noise: there is no other (dense/non-sparse) pose graph in Cartographer.

The name is used for a subdirectory of the code, for classes SparsePoseGraph and in the configuration as SPARSE_POSE_GRAPH and sparse_pose_graph.lua. Renaming it will break users who have to adapt their configurations.

Unless we can come up with an even better name, I propose dropping the word 'sparse'. Thoughts on this?

@ojura
Copy link
Contributor

ojura commented Nov 10, 2017

I like the name and how it's a reference to sparse pose adjustment.

Pose constraint systems, in typical robotic mapping applications,
exhibit a sparse structure of connections, since the range of
the sensor is typically limited to the vicinity of the robot.
In this paper, we develop a method to efficiently compute the
sparse matrix from the constraint graph, and use direct sparse
linear methods to solve it.

If you wanted to convey this, a more accurate name would be e.g. 'sparsely optimised pose graph' or 'SPA pose graph'. But that would be noise :-)

@cschuet
Copy link

cschuet commented Nov 10, 2017

I would also argue that since sparse pose graph is a known concept in SLAM it is useful to conserve it in the name.

@cschuet
Copy link

cschuet commented Nov 10, 2017

All further discussion on the RFC.

@cschuet cschuet closed this as completed Nov 10, 2017
wohe added a commit to cartographer-project/rfcs that referenced this issue Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants