Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add point_cloud_viewer color requirement note in asset writer doc #1424

Open
wants to merge 2 commits into
base: master
from

Conversation

@erikreed
Copy link

erikreed commented Nov 19, 2019

I was running through these docs and having trouble with map visualization via point_cloud_viewer. Notably, color is required for plys ingested by point_cloud_viewer (in contrast to Meshlab).

This PR adds a note to make this clear.

@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 19, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Nov 19, 2019
@erikreed

This comment has been minimized.

Copy link
Author

erikreed commented Nov 19, 2019

@googlebot I signed it!

@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 19, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Nov 19, 2019
Fix typo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.