Add point_cloud_viewer color requirement note in asset writer doc #1424
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Thanks! Please rebase your branch to the latest master and sign off your commits. The project has switched from the Google CLA to a DCO recently
|
|
@erikreed friendly ping Would be nice to get this merged. |
docs/source/assets_writer.rst
Outdated
| @@ -126,6 +126,7 @@ An example of such a pipeline is in `assets_writer_backpack_2d.lua`_. | |||
| .. _assets_writer_backpack_2d.lua: https://github.com/googlecartographer/cartographer_ros/blob/44459e18102305745c56f92549b87d8e91f434fe/cartographer_ros/configuration_files/assets_writer_backpack_2d.lua | |||
|
|
|||
| Once you have the ``.ply``, follow the README of `point_cloud_viewer`_ to generate an on-disk octree data structure which can be viewed by one of the viewers (SDL or web based) in the same repo. | |||
| Note that color is required for `point_cloud_viewer` to function. | |||
There was a problem hiding this comment.
If you want inline code highlighting, you need to use double backticks in RST. It's different to Markdown.
Signed-off-by: Erik Reed <ereed.uw@gmail.com>
|
Thanks for the ping -- I rebased and fixed the backticks 🍻 |
…ct#1424) I was running through these docs and having [trouble](cartographer-project/point_cloud_viewer#389) with map visualization via `point_cloud_viewer`. Notably, color is required for plys ingested by `point_cloud_viewer` (in contrast to Meshlab). This PR adds a note to make this clear. Signed-off-by: Erik Reed <ereed.uw@gmail.com>
…ct#1424) I was running through these docs and having [trouble](cartographer-project/point_cloud_viewer#389) with map visualization via `point_cloud_viewer`. Notably, color is required for plys ingested by `point_cloud_viewer` (in contrast to Meshlab). This PR adds a note to make this clear. Signed-off-by: Erik Reed <ereed.uw@gmail.com> Signed-off-by: Guillaume Doisy <guillaume.doisy@wyca.fr>
I was running through these docs and having trouble with map visualization via
point_cloud_viewer. Notably, color is required for plys ingested bypoint_cloud_viewer(in contrast to Meshlab).This PR adds a note to make this clear.