Cleanup. #203
Merged
Cleanup. #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damonkohler
approved these changes
Nov 30, 2016
doronhi
pushed a commit
to doronhi/cartographer_ros
that referenced
this pull request
Nov 27, 2018
This is done by replacing CMAKE_*_DIR variables with PROJECT_*_ variables so that CMake uses correct paths when libcartographer is a subproject Move AllFiles.cmake into the project binary dir instead of the root CMake binary dir, use a project-dependent detect_changes target name This makes overriding it from an upper level CMakeLists.txt possible, which is required when doing a super-build which doesn't require installing libcartographer.
doronhi
pushed a commit
to doronhi/cartographer_ros
that referenced
this pull request
Nov 27, 2018
This was missed in cartographer-project#203, where uses of absolute CMAKE_BINARY_DIR were changed to PROJECT_BINARY_DIR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.