Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proto3 install scripts to Dockerfiles and update docs. #589

Merged
merged 2 commits into from Nov 13, 2017
Merged

Add proto3 install scripts to Dockerfiles and update docs. #589

merged 2 commits into from Nov 13, 2017

Conversation

cschuet
Copy link

@cschuet cschuet commented Nov 13, 2017

No description provided.

@cschuet cschuet requested review from SirVer and removed request for athackst November 13, 2017 08:46
SirVer
SirVer reviewed Nov 13, 2017
View reviewed changes
docs/source/index.rst Outdated
../cmake
ninja
sudo ninja install

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, rather refer to the installation script in Cartographer.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

SirVer
SirVer approved these changes Nov 13, 2017
View reviewed changes
Copy link
Contributor

@SirVer SirVer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the one change request, lgtm.

@cschuet
Copy link
Author

cschuet commented Nov 13, 2017

@wally-the-cartographer merge

@wally-the-cartographer
Copy link

Merge requested by authorized user cschuet. Merge queue now has a length of 1.

@wally-the-cartographer wally-the-cartographer merged commit 5210e92 into cartographer-project:master Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirVer SirVer SirVer approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cschuet @wally-the-cartographer @SirVer @googlebot