Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do audits safely report they didn't complete? #36

Closed
paulirish opened this issue Mar 19, 2016 · 3 comments
Closed

How do audits safely report they didn't complete? #36

paulirish opened this issue Mar 19, 2016 · 3 comments

Comments

@paulirish
Copy link
Member

What should an audit return for statuses like "test not applicable" or "metric couldn't be computed", etc?

It's not reporting a test failure, nor a runtime exception.. @samccone recommended a result.fault state, which is what i tried out here

thoughts?

@samccone
Copy link
Contributor

+1 fault for now, it can be under specified a bit until we have a few more fails to abstract a "pattern" from

🐐 8️⃣ 🎉

@paullewis
Copy link
Contributor

So long as promises resolve I'm cool. We don't want rejects for anything other than exceptions. So we can resolve with a fault property if that works, though why not err?

@paulirish
Copy link
Member Author

merging this into #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants