first meaningful Paint metric #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var events = model.timelineModel().mainThreadEvents(); | ||
|
|
||
| var navStartEvent = events.filter(e => e.name === 'navigationStart'); | ||
| var firstTextPaintEvent = events.filter(e => |
There was a problem hiding this comment.
let's extract the filter body into a named function, (easier to test)
| var DevtoolsTimelineModel = require('devtools-timeline-model'); | ||
|
|
||
| module.exports = function(data) { | ||
| // FIXME(paulirish) save the trace to file in debug file for later analysis. |
There was a problem hiding this comment.
we should make a real issue for tracking this. I think we're going to want an easy way to save artifacts in general (e.g. for graphing over time a la bigrig)
|
Unfortunately the global It'll require some work to sort them out. |
|
|
paulirish
added a commit
that referenced
this pull request
Mar 21, 2016
first meaningful Paint metric
|
👌 ace work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sketching out how we share the fMP metric as described in #26.
Metrics broke out into separate folders, but matching the audit style so far, as they certainly share the inputs approach.