-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first meaningful Paint metric #31
Conversation
var events = model.timelineModel().mainThreadEvents(); | ||
|
||
var navStartEvent = events.filter(e => e.name === 'navigationStart'); | ||
var firstTextPaintEvent = events.filter(e => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's extract the filter body into a named function, (easier to test)
var DevtoolsTimelineModel = require('devtools-timeline-model'); | ||
|
||
module.exports = function(data) { | ||
// FIXME(paulirish) save the trace to file in debug file for later analysis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should make a real issue for tracking this. I think we're going to want an easy way to save artifacts in general (e.g. for graphing over time a la bigrig)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filed #35
Unfortunately the global It'll require some work to sort them out. |
|
first meaningful Paint metric
👌 ace work |
Sketching out how we share the fMP metric as described in #26.
Metrics broke out into separate folders, but matching the audit style so far, as they certainly share the inputs approach.