New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful recovery when no manifest is present #99

Closed

paulirish opened this issue Mar 29, 2016 · 1 comment · Fixed by #102

Assignees

Member

paulirish commented Mar 29, 2016

I suppose there's a few cases that we shouldn't bomb on.

link rel manifest not found in DOM
link rel manifest found, but it 404s
manifest asset retrieved but it's invalid JSON
manifest members are missing, and all that.

I think we have decent coverage here, but we may need to bulk up tests for the manifest gatherer.

@brendankenny wanna take a stab here?

Contributor

samccone commented Mar 30, 2016

gatherer should be in a fault state
audits should fail because the gatherer key is in an invalid state
each audit should show an error message as to why it is borked.
all done 🎉

brendankenny self-assigned this

brendankenny mentioned this issue

pipe manifest fetch/parse error strings up for display #102

Merged

samccone closed this as completed in #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment