Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new_audit(errors-in-console): Added new runtime exceptions #3494

Conversation

siteriaitaliana
Copy link
Contributor

@paulirish @patrickhulce @brendankenny as promised this the 2nd part of the errors-in-console, this should include the js errors now

afterPass(options) {
return Promise.resolve()
.then(_ => options.driver.off('Runtime.exceptionThrown', this._onRuntimeExceptionThrown))
.then(_ => options.driver.sendCommand('Runtime.disable'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nuke this. we'll keep Runtime domain on

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from that one bit, i think we're good here.

RuntimeExceptions: [{
'timestamp': 1506535813608.003,
'exceptionDetails': {
'url': 'http://www.inmotionhosting.com/support/templates/supportcentertemplate/js/fancybox.js',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test has a js failure dependency from this page, if they fix it it will start to fail, remove it as this is covered already from the new smoke test

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can these be switched to a more generic url instead of a real site? Something like 'http://example.com/fancybox.js' for the three instances of these should be fine

@brendankenny
Copy link
Member

@siteriaitaliana can you rebase from master? I believe that will fix the appveyor error but there are some new (minor) linting errors that will need to be fixed

@@ -35,6 +35,11 @@
<!-- FAIL: block rendering -->
<script src="./dbw_tester.js"></script>

<!-- Runtime Ecception thrown here to test the new runtime exception gatherer. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch to something like
<!-- FAIL(errors-in-console): exception thrown -->

RuntimeExceptions: [{
'timestamp': 1506535813608.003,
'exceptionDetails': {
'url': 'http://www.inmotionhosting.com/support/templates/supportcentertemplate/js/fancybox.js',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can these be switched to a more generic url instead of a real site? Something like 'http://example.com/fancybox.js' for the three instances of these should be fine

{
'timestamp': 1506535813608.003,
'exceptionDetails': {
'url': 'http://www.inmotionhosting.com/support/templates/supportcentertemplate/js/fancybox.js',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for these URLs

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@siteriaitaliana siteriaitaliana force-pushed the runtime-exceptions-in-chrome-msg-gatherer branch from fc46937 to 27e2d33 Compare October 17, 2017 10:07
@siteriaitaliana siteriaitaliana force-pushed the runtime-exceptions-in-chrome-msg-gatherer branch from 27e2d33 to d459e3c Compare October 17, 2017 10:12
@siteriaitaliana siteriaitaliana changed the title Added new runtime exceptions gatherer to include js console errors audit(errors-in-console): Added new runtime exceptions gatherer to include js console errors Oct 17, 2017
@siteriaitaliana siteriaitaliana changed the title audit(errors-in-console): Added new runtime exceptions gatherer to include js console errors audit(errors-in-console): Added new runtime exceptions Oct 17, 2017
@siteriaitaliana siteriaitaliana changed the title audit(errors-in-console): Added new runtime exceptions new_audit(errors-in-console): Added new runtime exceptions Oct 17, 2017
@siteriaitaliana
Copy link
Contributor Author

@paulirish @brendankenny @patrickhulce guys I've actioned what requested looks good to me now

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@brendankenny brendankenny merged commit 487bee6 into GoogleChrome:master Oct 17, 2017
@paulirish
Copy link
Member

awesome PR. thanks for this second round, @siteriaitaliana !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants