-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(driver): add driver.wsEndpoint() #3864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -30,6 +30,15 @@ class Connection { | |||
return Promise.reject(new Error('Not implemented')); | |||
} | |||
|
|||
|
|||
/** | |||
* @return {!Promise} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we still say !Promise<string>
here just it'll always be rejected?
lighthouse-core/gather/driver.js
Outdated
@@ -104,6 +104,10 @@ class Driver { | |||
return this._connection.disconnect(); | |||
} | |||
|
|||
wsEndpoint() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy/paste jsdoc or hopefully tsc smart enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add docs for which endpoint this is? And I can't imagine who would think otherwise, but probably worth noting that it's CRI-only
eb8bc5a
to
15a56c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % periods
lighthouse-core/gather/driver.js
Outdated
@@ -104,6 +104,15 @@ class Driver { | |||
return this._connection.disconnect(); | |||
} | |||
|
|||
/** | |||
* Get the browser WebSocket endpoint for devtools protocol clients like Puppeteer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add some punctuation :P
for assistance when working with puppeteer
ref #3837