core(driver): add driver.wsEndpoint() #3864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Nov 21, 2017
| @@ -30,6 +30,15 @@ class Connection { | |||
| return Promise.reject(new Error('Not implemented')); | |||
| } | |||
|
|
|||
|
|
|||
| /** | |||
| * @return {!Promise} | |||
There was a problem hiding this comment.
can we still say !Promise<string> here just it'll always be rejected?
lighthouse-core/gather/driver.js
Outdated
| @@ -104,6 +104,10 @@ class Driver { | |||
| return this._connection.disconnect(); | |||
| } | |||
|
|
|||
| wsEndpoint() { | |||
There was a problem hiding this comment.
copy/paste jsdoc or hopefully tsc smart enough?
There was a problem hiding this comment.
add docs for which endpoint this is? And I can't imagine who would think otherwise, but probably worth noting that it's CRI-only
paulirish
force-pushed
the
wsendpoint
branch
from
eb8bc5a
to
15a56c4
Compare
brendankenny
approved these changes
Nov 21, 2017
lighthouse-core/gather/driver.js
Outdated
| @@ -104,6 +104,15 @@ class Driver { | |||
| return this._connection.disconnect(); | |||
| } | |||
|
|
|||
| /** | |||
| * Get the browser WebSocket endpoint for devtools protocol clients like Puppeteer | |||
There was a problem hiding this comment.
maybe add some punctuation :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for assistance when working with puppeteer
ref #3837