core(web-inspector): keep all experiments disabled #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen running in DevTools
patrickhulce
reviewed
Dec 7, 2017
| global.Runtime.experiments.isEnabled = global.Runtime.experiments.isEnabled || (_ => false); | ||
| // DevTools runtime doesn't know about some experiments that DTM looks for | ||
| // To avoid exceptions, we assume all experiments are disabled | ||
| global.Runtime.experiments.isEnabled = (_ => false); |
There was a problem hiding this comment.
the fix we needed last time is just that this function existed? or did we really need to use the built-in?
There was a problem hiding this comment.
seems like we just needed this function to exist before https://github.com/GoogleChrome/lighthouse/pull/3497/files#diff-daa5294aa1f14b31b082e6155d79f2d3L29
patrickhulce
approved these changes
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes a conflict when LH runs in the devtools worker: