Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: improve devtools dark mode rendering #4232

Merged
merged 1 commit into from
Jan 12, 2018
Merged

report: improve devtools dark mode rendering #4232

merged 1 commit into from
Jan 12, 2018

Conversation

paulirish
Copy link
Member

fixes #3827 (what wasn't fixed in #4190)

Before and after:

image

FWIW, This does require some DevTools-side changes as well:

diff --git a/third_party/WebKit/Source/devtools/front_end/audits2/audits2Panel.css b/third_party/WebKit/Source/devtools/front_end/audits2/audits2Panel.css
index 3e4d2e86f0bb..200a48388d91 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits2/audits2Panel.css
+++ b/third_party/WebKit/Source/devtools/front_end/audits2/audits2Panel.css
@@ -49,7 +49,19 @@
 .lh-root {
   --report-menu-width: 0;
   user-select: initial;
-  background: #fff;
+  --lh-bg-color: #fff;
+  background-color: var(--lh-bg-color);
+}
+
+.-theme-with-dark-background .lh-root {
+  --lh-bg-color: hsl(0, 0%, 14%);
+  --secondary-text-color: hsl(0, 0%, 66%);
+  --report-secondary-border-color: hsl(0, 0%, 8%);
+}
+
+.-theme-with-dark-background .lh-root .lh-gauge {
+  --circle-background: hsl(0, 0%, 27%);
+  --inset-color: var(--lh-bg-color);
 }
 
 .lh-root .lh-container {

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better 👍

@paulirish paulirish merged commit 55354e6 into master Jan 12, 2018
@paulirish paulirish deleted the darktables branch January 12, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix report table display
3 participants