core: improved consumption of audit.details #4384
Conversation
| const kbDisplay = this.bytesToKbString(bytes); | ||
| const percentDisplay = Util.formatNumber(Math.round(percent)) + '%'; | ||
| return `${kbDisplay} (${percentDisplay})`; | ||
| static bytesToDetails(bytes) { |
| * @return {!Element} | ||
| */ | ||
| _renderBytes(details) { | ||
| let text = Util.formatNumber(details.value, details.granularity || 0); |
There was a problem hiding this comment.
seems like we should either be using Util.formatBytesToKB or the nonexistent Util.formatBytes, but just falling back to formatNumber seems wrong to me.
There was a problem hiding this comment.
this should never even happen, so I don't have a strong opinion on how it's handled buuuuuuut... creating a new helper function that is never called does seem a bit silly, so I'm inclined to say we just always do formatBytesToKB and console.warn if display unit isn't kb?
that was because details is still fragile and annoying based on the fact that adding a new column would require rebasing all of our tests. IMO I still don't really see it as a wholesale replacement of extendedInfo in terms of ergonomics, if people rely on array indices to be stable they'll be more disappointed than just using extendedInfo maybe we should work out exactly how we expect people to consume this data and what we want to guarantee as stable? doesn't seem like we can guarantee the text of the headers to be the same and certainly not the index of the column, so extendedInfo-style might actually be a better bet |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
Remaining audits that need to be adapted:
|
patrickhulce
changed the title
patrickhulce
force-pushed
the
(╯°□°）╯︵┻━┻_the_strings
branch
from
a23a010
to
b08335f
Compare
|
Update: moved to #4616 Here's my initial take at merging extInfo and details together and using proper key names: http://bit.ly/2HDIk8q (lol the branch name hit a github bug. :) Also here's a LHR this branch produces: |
paulirish
modified the milestones:
Sprint Nueve: Feb 12 - Feb 23,
Sprint Diez: Feb 26 - Mar 9
|
This is LGTM. |
Hello 3️⃣ ⚫️ 0️⃣ ! |
moves us toward #4614 (and #3115), really helps out using details data
@paulirish did you still want to tackle the rest or is this for me? :) either way should we bring the issue in to ocho and assign it?