Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(programmatic): add caveat about removing artifacts #4540

Merged
merged 3 commits into from
Feb 20, 2018

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Feb 14, 2018

closes #4346

@patrickhulce
Copy link
Collaborator Author

does this help @ganlanyuan?

@ganlanyuan
Copy link

Yes, that's helpful!
Thanks

@ganlanyuan
Copy link

But this doesn't work for me, I just get the results of undefined:

return lighthouse(url, opts, config).then(results => {
  delete results.artifacts;
  chrome.kill().then(() => {
    return new ReportGenerator().generateReportHtml(results);
  })});

While this works:

return lighthouse(url, opts, config).then(results =>
  chrome.kill().then(() => {
    delete results.artifacts;
    return new ReportGenerator().generateReportHtml(results);
  }));

@paulirish
Copy link
Member

@ganlanyuan this is true. implicit return. updated the code to be more obvious about this. :)

@GoogleChrome GoogleChrome deleted a comment from googlebot Feb 14, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@patrickhulce patrickhulce merged commit ee98193 into master Feb 20, 2018
@patrickhulce patrickhulce deleted the patrickhulce-patch-1 branch February 20, 2018 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update programmatic example to delete results.artifacts
5 participants