Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to the indexing audit reference #4678

Merged
merged 3 commits into from
Mar 7, 2018
Merged

link to the indexing audit reference #4678

merged 3 commits into from
Mar 7, 2018

Conversation

kaycebasques
Copy link
Contributor

No description provided.

@@ -63,8 +63,9 @@ class IsCrawlable extends Audit {
name: 'is-crawlable',
description: 'Page isn’t blocked from indexing',
failureDescription: 'Page is blocked from indexing',
helpText: 'The "Robots" directives tell crawlers how your content should be indexed. ' +
'[Learn more](https://developers.google.com/search/reference/robots_meta_tag).',
helpText: 'Search engines are less likely to include your pages in search results ' +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as google/WebFundamentals#5857 (comment) regarding "less likely"

Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@paulirish paulirish merged commit bd2c6e6 into master Mar 7, 2018
@paulirish paulirish deleted the docs-indexing branch March 7, 2018 18:11
@rviscomi
Copy link
Member

rviscomi commented Mar 7, 2018

@paulirish should I be merging as soon as I approve?

@rviscomi
Copy link
Member

rviscomi commented Mar 8, 2018

Progress on #4355

@paulirish
Copy link
Member

@rviscomi for changes this trivial, sure. :)

we do squash merges btw. and typically delete the body of the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants