core: make url-shim extend native URL module; add type checking #4712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
diff is much better at https://github.com/GoogleChrome/lighthouse/pull/4712/files?w=1. PR is primarily indentation into a class body :) |
paulirish
approved these changes
Mar 8, 2018
There was a problem hiding this comment.
This moves us back to extending URL, which was removed in #1407. If anyone can remember why we did that at the time
I don't. But...
That was the time Viewer was becoming a thing. And here was a es5 transpilation target in the viewer gulpfile at the time:
And that was removed in #2521. So yeah I think we're good.
|
that's some nice archaeology! |
paulirish
pushed a commit
that referenced
this pull request
Mar 15, 2018
paulirish
added a commit
that referenced
this pull request
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds type checking to URLShim. removes
whatwg-urlnow that Node 8 is required (fixes #1186)This moves us back to extending
URL, which was removed in #1407. If anyone can remember why we did that at the timeplease let me know, but for now CLI and extension seem to work fine with this change.