Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(closure): avoid failing closure compilation #4737

Merged
merged 1 commit into from
Mar 12, 2018
Merged

tests(closure): avoid failing closure compilation #4737

merged 1 commit into from
Mar 12, 2018

Conversation

paulirish
Copy link
Member

This is most definitely a closure compiler bug. But this reordering fixes #4735

brendankenny
brendankenny approved these changes Mar 12, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! 👍🔍🕵️

@brendankenny
Copy link
Member

(waiting on CI)

@brendankenny brendankenny merged commit ca07b99 into master Mar 12, 2018
@brendankenny brendankenny deleted the fixclosuredevtools branch March 12, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@vinamratasingal-zz vinamratasingal-zz Awaiting requested review from vinamratasingal-zz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compile-devtools is failing
2 participants
@paulirish @brendankenny