core(network-analyzer): more distrustful of chrome connection info #4828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
force-pushed
the
fix_extension_stable
branch
from
d014200
to
59359a0
Compare
paulirish
approved these changes
Mar 20, 2018
|
lint & line length. ;) |
brendankenny
approved these changes
Mar 20, 2018
| * @return {boolean} | ||
| */ | ||
| static canTrustConnectionInformation(records) { | ||
| const connectionIdWasStarted = new Map(); |
There was a problem hiding this comment.
connectionIdWasNew or something like that, maybe? As stand more opposite to connectionReused
| } | ||
|
|
||
| // We probably can't trust the network information if all the connection IDs were the same | ||
| if (connectionIdWasStarted.size <= 1) return false; |
There was a problem hiding this comment.
could this happen for a single request page? (or am I missing the nature of connections? :)
There was a problem hiding this comment.
most definitely, but in that case it won't matter since our inferred result will be identical to the real data
|
can you do me a favor and nuke these: lighthouse/lighthouse-extension/test/extension-test.js Lines 154 to 155 in f092a8a |
patrickhulce
force-pushed
the
fix_extension_stable
branch
from
c9abcd6
to
aae64d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://travis-ci.org/paulirish/lighthouse/jobs/356048954#L602
huge 👏 to @paulirish for struggling through layers of docker/extension/puppeteer to get me a devtools log of this happening