core(lantern): more flexible graph edge creation #4933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
force-pushed
the
appveyor_flake
branch
from
d463482
to
3e9f29a
Compare
patrickhulce
changed the title
brendankenny
approved these changes
Apr 9, 2018
| } | ||
|
|
||
| if (process.env.APPVEYOR) { | ||
| // Appveyor is hella slow already, disable CPU throttling so we're not 16x slowdown |
paulirish
approved these changes
Apr 9, 2018
| const command = 'node'; | ||
| const args = [ | ||
| 'lighthouse-cli/index.js', | ||
| url, | ||
| `--config-path=${configPath}`, | ||
| `--output-path=smokehouse.report.json`, |
There was a problem hiding this comment.
I often run yarn smokehouse and yarn smoke simultaneously which could conflict in this scenario.
also my smokehouse revamp PR means we'll have a lot of these running at the same time.
how about something like:
const filename = `smokehouse${Math.round(Math.random()*1000))}.report.json`;There was a problem hiding this comment.
if we go down this path, can we delete the report by default then? :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4891
this should fix the appveyor flakiness we've been seeing which was 3-pronged
also I made smokehouse a bit more debuggable by using output-path for the JSON instead of stdout and adding a ENV variable to print stdout