core(config): remove config.artifacts; always use auditMode #4986
Conversation
brendankenny
requested review from
patrickhulce,
paulirish and
vinamratasingal-zz
as code owners
| @@ -115,7 +113,8 @@ class Runner { | |||
| const resultsById = {}; | |||
| for (const audit of auditResults) resultsById[audit.name] = audit; | |||
|
|
|||
| let reportCategories; | |||
| /** @type {Array<LH.Result.Category>} */ | |||
| let reportCategories = []; | |||
There was a problem hiding this comment.
part of the discussed change to default to having an empty categories array, even if none in the config (we could maybe start defaulting to [] in the config, but we'll see)
| @@ -0,0 +1,14 @@ | |||
| [ | |||
There was a problem hiding this comment.
copied over from fixtures/traces/trace-user-timings.json cause it was small and we really only need to test the loading part :)
| @@ -60,7 +60,7 @@ module.exports = { | |||
| }, | |||
| beginDevtoolsLog() {}, | |||
| endDevtoolsLog() { | |||
| return require('../fixtures/perflog.json'); | |||
| return require('../fixtures/artifacts/perflog/defaultPass.devtoolslog.json'); | |||
There was a problem hiding this comment.
this was big, so just moved over to the artifacts fixtures and moved the two tests using it to point at the new path
| @@ -148,25 +148,6 @@ describe('Runner', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('accepts existing artifacts', () => { | |||
There was a problem hiding this comment.
overlap with lots of other -GA and auditMode tests, so removed
| @@ -87,18 +87,17 @@ describe('Module Tests', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| it.skip('should return formatted audit results when given no categories', function() { | |||
| it('should return formatted LHR when given no categories', function() { | |||
There was a problem hiding this comment.
this was skipped when -GA was added. Reenabled :P
| // and to change TracingStartedInBrowser events into TracingStartedInPage. | ||
| // This is done by searching for most occuring threads and basing new events | ||
| // off of those. | ||
| function cleanTrace(trace) { |
There was a problem hiding this comment.
what a beautiful sight :D
There was a problem hiding this comment.
aye. this removes support for traces captured by webdriver, but at this point, i'm just fine with that. :)
| @@ -782,11 +666,6 @@ class Config { | |||
| return this._audits; | |||
| } | |||
|
|
|||
| /** @type {Array<!Artifacts>} */ | |||
| get artifacts() { | |||
part of #4333
remove support for artifacts loaded in the config and the kind of wonky way it loaded traces and devtoolsLogs from there. Now the official way to load artifacts and skip the gather step is with
--audit-mode/auditModein the config.Required creating some artifacts fixtures to port over old tests that loaded with
config.artifacts, but on the plus side it means more tests for--audit-mode.