Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: split up parallel smoketests into 2 batches #4996

Merged
merged 3 commits into from
Apr 20, 2018
Merged

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Apr 19, 2018

Used some data to split these into batches of similar size. (hopefully)

results from travis

total time for smoketests:

. run 1 run 2 run 3 run 4
2 batches 213s 237s 217s 219s
3 batches 233s 208s 234s 244s

run 2 was just whack, i guess..

This reverts commit d434fe4.
@paulirish paulirish changed the title tests: split up parallel smoketests into 2 batches (WIP) tests: split up parallel smoketests into 2 batches Apr 19, 2018
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 still slightly concerned about the tricky-ttci test being useful in this context as discussed in #4997 (taking ~40s on travis compared to ~20s locally) but better than nothing, so I'm cool

@paulirish paulirish merged commit 8ae7e48 into master Apr 20, 2018
@paulirish paulirish deleted the smokebatches branch April 20, 2018 00:20
kdzwinel pushed a commit to kdzwinel/lighthouse that referenced this pull request Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants