tests(viewer): add pptr test for viewer #5025
Conversation
| assert.deepStrictEqual(pageErrors, []); | ||
| }); | ||
|
|
||
| it('should contain all categories', async () => { |
There was a problem hiding this comment.
below is all basically identical to the extension test
| } else { | ||
| // Otherwise, disallow file requests outside of LH folder or from node_modules | ||
| const filePathDir = path.parse(absoluteFilePath).dir; | ||
| if (!filePathDir.startsWith(lhRootDirPath) || filePathDir.includes('node_modules')) { |
There was a problem hiding this comment.
drive-by tightening :)
| await viewerPage.goto(viewerUrl, {waitUntil: 'networkidle2'}); | ||
| const fileInput = await viewerPage.$('#hidden-file-input'); | ||
| await fileInput.uploadFile(sampleLhr); | ||
| await viewerPage.waitForSelector('.lh-container'); |
There was a problem hiding this comment.
Do you want to set a smaller timeout for this and goto? Default is 30s. If the link fails, we should know about it sooner. Speed up the tests.
There was a problem hiding this comment.
whoops, yes, misread that as 3s and thought it sounded great :)
|
|
||
| const selectors = { | ||
| audits: '.lh-audit,.lh-timeline-metric,.lh-perf-hint', | ||
| titles: '.lh-score__title, .lh-perf-hint__title, .lh-timeline-metric__title', |
There was a problem hiding this comment.
spaces here too: '.lh-audit, .lh-timeline-metric, .lh-perf-hint',
| }; | ||
|
|
||
| it('should load with no errors', async () => { | ||
| assert.deepStrictEqual(pageErrors, []); |
There was a problem hiding this comment.
lol. just check pageErrors.length === 0
There was a problem hiding this comment.
just check pageErrors.length === 0
I got the idea from the audit errors check below when I had errors at first. The error diff prints out the errors the page was seeing (instead of x !== 0), which is actually pretty nice when things go wrong and you don't have to do an extra debug step to print them
| browser = await puppeteer.launch({ | ||
| headless: false, | ||
| executablePath: process.env.CHROME_PATH, | ||
| args: [], |
|
|
||
| // start puppeteer | ||
| browser = await puppeteer.launch({ | ||
| headless: false, |
There was a problem hiding this comment.
why do we need headful?
...we're testing as a user? I don't know, I copied from #4640 :) Does it really matter in this instance?
There was a problem hiding this comment.
Ah yea. That's because extensions dont work in headless. You could use headless here but I'm not sure it really matters.
There was a problem hiding this comment.
headless! lets do it.
used it over there because extensions yes.
There was a problem hiding this comment.
headless! lets do it.
done
| }); | ||
| viewerPage = await browser.newPage(); | ||
| viewerPage.on('pageerror', pageError => pageErrors.push(pageError)); | ||
| await viewerPage.goto(viewerUrl, {waitUntil: 'networkidle2'}); | ||
| await viewerPage.goto(viewerUrl, {waitUntil: 'networkidle2', timeout: 3000}); |
There was a problem hiding this comment.
These will throw if they timeout. Do you want to catch those as errors?
There was a problem hiding this comment.
These will throw if they timeout. Do you want to catch those as errors?
I think it's fine? It'll throw and fail in before, which will fail the tests.
| const auditErrors = await viewerPage.$$eval('.lh-debug', getDebugStrings, selectors); | ||
| const errors = auditErrors.filter(item => item.debugString.includes('Audit error:')); | ||
| const unexpectedErrrors = errors.filter(item => { | ||
| return !item.debugString.includes('Required RobotsTxt gatherer did not run'); |
There was a problem hiding this comment.
can you confirm the savedartifacts are out of date?
There was a problem hiding this comment.
yeah, no RobotsTxt artifact in artifacts.json
|
|
||
| // start puppeteer | ||
| browser = await puppeteer.launch({ | ||
| headless: false, |
There was a problem hiding this comment.
headless! lets do it.
used it over there because extensions yes.
| executablePath: process.env.CHROME_PATH, | ||
| }); | ||
| viewerPage = await browser.newPage(); | ||
| viewerPage.on('pageerror', pageError => pageErrors.push(pageError)); |
|
travis seems to be unhappy though |
brendankenny
force-pushed
the
vwrpptr
branch
3 times, most recently
from
48085fb
to
3154866
Compare
|
travis unhappiness was due to report changes in #5009. extension test got updates for that but this obviously did not :) |
As we start major work again on the report, it'd be good to have an easy way to verify we aren't breaking viewer. While viewer does already have compile and (a few) basic unit tests, this PR rips off @wardpeet's hard work from #4640 to make a pptr integration test for viewer as well.
Ideally we'd extract some sort of "use puppeteer to test a live report interface" test and have each individual directory file only in charge of setup and teardown, but I think(?) this is sufficient for now as we have more pressing matters.