Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(snyk): update snyk snapshot #5074

Merged
merged 2 commits into from
May 1, 2018
Merged

Conversation

grnd
Copy link
Contributor

@grnd grnd commented Apr 30, 2018

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@grnd
Copy link
Contributor Author

grnd commented May 1, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@paulirish
Copy link
Member

Thx!

For posterity, here's the diff between our current snapshot and this one:
https://gist.github.com/paulirish/3ee8d1a9fb7afa5f1688f0b5b80aa417

The jquery lib change is down at L167 of the diff.

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thank you!

@paulirish paulirish merged commit 2a20fab into GoogleChrome:master May 1, 2018
@paulirish
Copy link
Member

@grnd btw I don't expect the test fixtures requiring and update with these rolls, unless jquery@2.1.1 is affected. But thanks for updating it this time! Nice job figuring it out. :D

kdzwinel pushed a commit to kdzwinel/lighthouse that referenced this pull request Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants