core(tsc): more type checking of top-level audits #5089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added unit test for new failure case in time-to-first-byte where somehow we end up with a finalUrl without a network record for it, which should be impossible considering finalUrl comes from the network records :) Maybe some -GA mismatch situation |
paulirish
approved these changes
May 2, 2018
| @@ -30,8 +32,8 @@ class ScreenshotThumbnails extends Audit { | |||
| * Scales down an image to THUMBNAIL_WIDTH using nearest neighbor for speed, maintains aspect | |||
| * ratio of the original thumbnail. | |||
| * | |||
| * @param {{width: number, height: number, data: !Array<number>}} imageData | |||
| * @return {{width: number, height: number, data: !Array<number>}} | |||
There was a problem hiding this comment.
do we want to reference the speedlineoutput.frames type instead?
patrickhulce
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multi-check audits, screenshots and viewport