core(tsc): add type checking for seo audits #5103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all of lighthouse-core/**/*.js!
paulirish
approved these changes
May 3, 2018
patrickhulce
approved these changes
May 3, 2018
| @@ -34,17 +39,17 @@ function getUniqueFailingRules(fontSizeArtifact) { | |||
| } | |||
| }); | |||
|
|
|||
| return failingRules.valuesArray(); | |||
| return [...failingRules.values()]; | |||
There was a problem hiding this comment.
I'd have an extraordinarily small preference for Array.from, mostly commenting out of curiosity if this is your preference? :)
There was a problem hiding this comment.
hmm, I used to prefer Array.from since it felt more deliberate and less like an action in place or something, but now I have spread blindness and see them as the same thing, so I don't think I care anymore...
| @@ -89,14 +90,14 @@ class IsCrawlable extends Audit { | |||
| if (isBlocking) { | |||
| blockingDirectives.push({ | |||
| source: { | |||
| type: 'node', | |||
| type: /** @type {'node'} */ ('node'), | |||
| "lighthouse-core/lib/emulation.js", | ||
| "lighthouse-core/gather/**/*.js", | ||
| "lighthouse-core/scripts/*.js", | ||
| "lighthouse-core/**/*.js", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with this, all of
lighthouse-core/**/*.jsis type checked :) (with carve outs for tests and the html renderer, for now).The only remaining files this adds are these seo audits and the all-important
empty-stub.js(which turns out was already type safe! Good jobempty-stub).