report: implement new design for opportunities #5115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
few UI notes:
|
patrickhulce
reviewed
May 4, 2018
| this.dom.find('.lh-load-opportunity__sparkline', tmpl).title = displayValue; | ||
| this.dom.find('.lh-load-opportunity__wasted-stat', tmpl).title = displayValue; | ||
| this.dom.find('.lh-sparkline__bar', tmpl).style.width = summaryInfo.wastedMs / scale * 100 + '%'; | ||
| this.dom.find('.lh-load-opportunity__wasted-stat', tmpl).textContent = Util.formatSeconds(summaryInfo.wastedMs); |
There was a problem hiding this comment.
we should probably filter on wastedMs < 50 now that it could show 0 s
| @@ -116,6 +116,16 @@ class Util { | |||
| return `${coarseTime.toLocaleString()}${NBSP}ms`; | |||
| } | |||
|
|
|||
| /** | |||
| * @param {number} ms | |||
| * @param {number=} granularity Controls how coarse the displayed value is, defaults to 10 | |||
| if (!summaryInfo || !summaryInfo.wastedMs) { | ||
| return element; | ||
| } | ||
|
|
||
| const elemAttrs = {title: Util.formatDisplayValue(audit.result.displayValue)}; | ||
| const sparklineContainerEl = this.dom.createChildOf(summary, 'div', |
| color: var(--medium-75-gray); | ||
| text-align: center; | ||
| display: unset; | ||
| line-height: 40px; |
There was a problem hiding this comment.
is this some variable +/* some padding?
| margin: 0 5px; | ||
| } | ||
| .lh-load-opportunity__col--one { | ||
| flex: 5; |
There was a problem hiding this comment.
I must say this was slightly magical to me given the header and details have different content, I have much to learn 📖 🤓
brendankenny
approved these changes
May 4, 2018
…images'" This reverts commit c22e047.
paulirish
added a commit
that referenced
this pull request
May 5, 2018
kdzwinel
pushed a commit
to kdzwinel/lighthouse
that referenced
this pull request
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
screenshots
example reports:
https://lonely-lumber.surge.sh/cnn.html
https://lonely-lumber.surge.sh/tinyhouse.html
https://lonely-lumber.surge.sh/dbwtester.html
https://lonely-lumber.surge.sh/example.html
https://lonely-lumber.surge.sh/paulirish.html
https://lonely-lumber.surge.sh/cnn.devtools.html
https://lonely-lumber.surge.sh/tinyhouse.devtools.html
https://lonely-lumber.surge.sh/dbwtester.devtools.html
https://lonely-lumber.surge.sh/example.devtools.html
https://lonely-lumber.surge.sh/paulirish.devtools.html
ref #5008