core(lhr): move runtime config to report, configSettings

[patrickhulce]

• removes runtimeConfig from LHR
• adds runtimeSettings to LHR (I'd prefer just .settings but doing the rename of that back to something else would have been more challenging, so lmk if other folks feel the same I'd I'll happily change :D)
• moves the emulation description logic to the report renderer

I know that this whole thing is ripe for some refactoring, but we've got a long list to get through and this keeps same functional parity, sooooo

NOTE: closure fixes pending

[paulirish]

works for me. naming proposal tho.

[paulirish]

wdyt configSettings? that's what we call them elsewhere.

[patrickhulce]

sg done

[brendankenny]

LGTM2!

One surprise people may have is extraHeaders being saved in the LHR/report if they're using them for authentication, but I guess the URL of their dev server or whatever is already in there and if they're comfortable sharing a report with that in it...

We could make the headers (if any) visible in the "Runtime settings" section of the report as a warning that they're in the file, though that's collapsed by default so it might not add much.

[brendankenny]

this is going to be great to have

[brendankenny]

I know that this whole thing is ripe for some refactoring

did you mean in how we generate things in getEmulationDesc or more? Make sure to make a note of it :)