-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report(header): new header WIP #5125
Conversation
wardpeet
commented
May 4, 2018
😮 👏 👏 👏 👏 👏 👏 |
LGTM! Thanks Ward :) cc: @hwikyounglee |
Nice! Don't worry about the runtime settings for now. We can wrestle with that. Can you address the conflicts? (sorry, renderer is conflict party these days. :) |
4f1904d
to
d1bbff2
Compare
Thanks @wardpeet! One suggestion is to show 1) URL and 2) chevron for the runtime settings in the collapsed state. |
@hwikyounglee paul had some ideas around that but I could fix the url moving |
hwi's ideas are better than mine on the runtime settings, tbh. :) if you want to take a shot on that, be my guest. |
cbc8eb2
to
cbbb20a
Compare
@hwikyounglee @paulirish |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |