Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report(header): new header WIP #5125

Merged
merged 15 commits into from
May 9, 2018
Merged

report(header): new header WIP #5125

merged 15 commits into from
May 9, 2018

Conversation

wardpeet
Copy link
Collaborator

@wardpeet wardpeet commented May 4, 2018

image

@patrickhulce
Copy link
Collaborator

😮 👏 👏 👏 👏 👏 👏

@vinamratasingal-zz
Copy link

LGTM! Thanks Ward :)

cc: @hwikyounglee

@paulirish
Copy link
Member

Nice! Don't worry about the runtime settings for now. We can wrestle with that.

Can you address the conflicts?

(sorry, renderer is conflict party these days. :)

@wardpeet
Copy link
Collaborator Author

wardpeet commented May 7, 2018

I still have one test to fix.

Header:
image

25%:
image

50%:
image

75%:
image

100%:
image

@hwikyounglee
Copy link

hwikyounglee commented May 7, 2018

Thanks @wardpeet!

One suggestion is to show 1) URL and 2) chevron for the runtime settings in the collapsed state.
header-url

@wardpeet
Copy link
Collaborator Author

wardpeet commented May 8, 2018

@hwikyounglee paul had some ideas around that but I could fix the url moving

@paulirish
Copy link
Member

hwi's ideas are better than mine on the runtime settings, tbh. :) if you want to take a shot on that, be my guest.

@wardpeet
Copy link
Collaborator Author

wardpeet commented May 8, 2018

@hwikyounglee @paulirish
this is the best I could do for the limited time :(
image

image

@paulirish paulirish added the 3.0 label May 9, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@paulirish paulirish merged commit e5bcb7e into master May 9, 2018
@paulirish paulirish deleted the feature/report-header branch May 9, 2018 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants