Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: improved text-wrapping.... #5138

Merged
merged 3 commits into from
May 6, 2018
Merged

report: improved text-wrapping.... #5138

merged 3 commits into from
May 6, 2018

Conversation

paulirish
Copy link
Member

break-word makes a surprising amount of difference. It's excellent.

And fixing dom-size audit, as it can get pretty funky.

Before and after:
image
image

This PR isn't dependent on any others yay.

@paulirish paulirish changed the title report: improved text-wrapping report: improved text-wrapping. May 6, 2018
@paulirish paulirish changed the title report: improved text-wrapping. report: improved text-wrapping May 6, 2018
@paulirish paulirish changed the title report: improved text-wrapping report: improved text-wrapping. May 6, 2018
@paulirish paulirish changed the title report: improved text-wrapping. report: improved text-wrapping.. May 6, 2018
@paulirish paulirish changed the title report: improved text-wrapping.. report: improved text-wrapping... May 6, 2018
@paulirish paulirish changed the title report: improved text-wrapping... report: improved text-wrapping.... May 6, 2018
@paulirish paulirish requested a deployment to PR staging May 6, 2018 05:12 Pending
patrickhulce
patrickhulce approved these changes May 6, 2018
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@paulirish paulirish merged commit 3b56abf into master May 6, 2018
@paulirish paulirish deleted the details-wrapping branch May 6, 2018 21:11
kdzwinel pushed a commit to kdzwinel/lighthouse that referenced this pull request Aug 16, 2018
@paulirish @kdzwinel
report: improved text-wrapping (GoogleChrome#5138)
effab3f
@paulirish paulirish mentioned this pull request May 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny

@vinamratasingal-zz vinamratasingal-zz Awaiting requested review from vinamratasingal-zz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulirish @patrickhulce