Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: minimum time scale, text tweaks #5183

Merged
merged 5 commits into from
May 11, 2018
Merged

report: minimum time scale, text tweaks #5183

merged 5 commits into from
May 11, 2018

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented May 10, 2018

drive-by I/O polish I noticed while doing demos

  • Unused CSS Rules inconsistent name
  • minimum filmstrip scale 3s
  • minimum opportunity scale of 2s

EDIT: removed the share dropdown fix since ward already put up a PR :D #5185

@paulirish paulirish requested a deployment to PR staging May 11, 2018 18:11 Pending
@patrickhulce patrickhulce changed the title report: min scale, share dropdown, text tweaks report: minimum time scale, text tweaks May 11, 2018
@paulirish paulirish requested a deployment to PR staging May 11, 2018 18:13 Pending
@paulirish paulirish changed the title report: minimum time scale, text tweaks report: minimum time scale, text tweaks. May 11, 2018
@@ -19,7 +19,7 @@ class UnusedCSSRules extends ByteEfficiencyAudit {
static get meta() {
return {
name: 'unused-css-rules',
description: 'Unused CSS rules',
description: 'Remove unused CSS',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe

Remove or defer unused CSS

@patrickhulce patrickhulce changed the title report: minimum time scale, text tweaks. report: minimum time scale, text tweaks May 11, 2018
@paulirish paulirish merged commit d3f1b3a into master May 11, 2018
@paulirish paulirish deleted the io_polish branch May 11, 2018 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants