Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(releasing): minor updates #5345

Merged
merged 4 commits into from
Sep 27, 2018
Merged

docs(releasing): minor updates #5345

merged 4 commits into from
Sep 27, 2018

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented May 24, 2018

update: see #5345 (comment)

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apparently missed when we started npmignoring smokehouse. We need to be sure we aren't shipping something buggy, so it seems like this needs to be one of

  • don't npmignore smokehouse. It's not that big, and if it somehow is we could do something like just include a subset with that don't have large local files
  • write a test to automate testing a gzipped lighthouse package
  • include a checklist here of expected audit results for paulirish.com and example.com so we verify that it's not only running but that it's running correctly

@brendankenny
Copy link
Member

wait, it's still not ignored?

!lighthouse-cli/test/smokehouse

@paulirish
Copy link
Member Author

@brendankenny blast from the past. ;)

changes
  • lighthouse-core/scripts wasn't ignored correctly. their syntax is odd if you want most files in a dir ignored but one allowed. this works though.
  • keep all of lighthouse-cli/tests. most notably all the fixtures to support smokehouse
  • ignore latest-run
  • remove mentions of yarn smokehouse since that died here.
  • remove the "drive-by-tightening" that doesnt seem to help and actually prevents the npm explore lighthouse -- npm run smoke from working.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌬️LGTM!

lighthouse-cli/types/*.js
lighthouse-cli/types/*.map
# keep smokehouse tests, etc
!lighthouse-cli/test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how much bigger does our package end up?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh this was not fun. turns out yarn pack builds things VERY differently than npm pack.
and npm pack gives basically the same package before and after this PR. wonderful.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out it's smaller now. because the npmignore in master includes all of lighthouse-cli already.

so aint that somethin

@paulirish paulirish merged commit e15f87d into master Sep 27, 2018
@paulirish paulirish deleted the paulirish-patch-1 branch September 27, 2018 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants