core(user-timings): add back startTime #5442
Conversation
| @@ -118,6 +118,7 @@ class UserTimings extends Audit { | |||
| const time = item.isMark ? item.startTime : item.duration; | |||
| return { | |||
| name: item.name, | |||
| startTime: item.startTime, | |||
There was a problem hiding this comment.
can you assert this in user-timing-test?
| @@ -118,6 +118,7 @@ class UserTimings extends Audit { | |||
| const time = item.isMark ? item.startTime : item.duration; | |||
| return { | |||
| name: item.name, | |||
| startTime: item.startTime, | |||
| timingType: item.isMark ? 'Mark' : 'Measure', | |||
| time, | |||
There was a problem hiding this comment.
just noticed.. this name seems pretty weak. duration? timeInMs?
There was a problem hiding this comment.
agreed, duration and startTime are better names, and they match the standard names
There was a problem hiding this comment.
well that name is weak because it's either or and just for display, I added duration separately, but programmatic folks should probably just ignore time
maybe update to timeToDisplay?
There was a problem hiding this comment.
it's always been a bit odd that we share a column for two diff types of values
how about we add a second column, then we can be really clear with Start time and Duration. wdyt?
done |
Related Issues/PRs
closes #5418