Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove no-mutation-events audit & js callstack method #5509

Merged
merged 2 commits into from
Jun 18, 2018

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Jun 15, 2018

Summary

  • The no-mutation-events audit is the only audit using a large chunk of heavy/slow gatherer code.
  • Only 0.8% (3,370/435,697) of sites in HTTPArchive have even a single mutation event listener.
  • The gatherer would need fixing to land core: enable async stacks #5504
  • All the similar DBW audits were replaced by Chrome violations

If this becomes a priority again after passing our new audit process standards, then we still have this diff to look back on or it can become a Chrome violation to be picked up for free :)


comment from the future (paul in nov 2021): this PR also removes some captureJSCallUsage() weird stuff . it relied on Error.prepareStackTrace which is a wild lil API. We also found that some websites overwrite window.Error with something and this caused problems: #1194

This PR removes all that so those websites can continue to be a menace but we no longer care.

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm. can you file an issue for adding a violation to Chrome for use of mutation events?


you have a few more lines to remove in dbw_tester.js

@patrickhulce
Copy link
Collaborator Author

patrickhulce commented Jun 15, 2018

you have a few more lines to remove in dbw_tester.js

done

https://bugs.chromium.org/p/chromium/issues/detail?id=719009

@paulirish
Copy link
Member

you have a few more lines to remove in dbw_tester.js

done

pushed?

@patrickhulce
Copy link
Collaborator Author

pushed now

What were your mutation event listener findings? :)

@patrickhulce
Copy link
Collaborator Author

@brendankenny you were 👍 on this, right?

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like event-helpers might be only used in the audit as well?

Also need to delete the EventListeners artifact in artifacts.d.ts

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM!

@patrickhulce
Copy link
Collaborator Author

it looks like event-helpers might be only used in the audit as well?

the things I can still learn exist 😮

@patrickhulce patrickhulce merged commit 4b14f7e into master Jun 18, 2018
@patrickhulce patrickhulce deleted the remove_no_mutation_events branch June 18, 2018 16:20
@paulirish paulirish changed the title core: remove no-mutation-events audit core: remove no-mutation-events audit & js callstack method Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants