report(i18n): use LHR locale for toLocaleString #5734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
|
Now that #5746 is in, we'll want a test here that confirms we use whatever locale |
brendankenny
force-pushed
the
i18n_renderer_numbers_locale
branch
from
32647b8
to
196155d
Compare
| @@ -61,7 +64,7 @@ class ReportRenderer { | |||
| container.appendChild(this._renderReport(clone)); | |||
|
|
|||
| // put the UIStrings back into original state | |||
| ReportRenderer.updateAllUIStrings(clonedStrings); | |||
| ReportRenderer.updateAllUIStrings(originalUIStrings); | |||
There was a problem hiding this comment.
updated because it was a little confusing with clone being the cloned LHR, while clonedStrings was the clone of the original Util.UIStrings, not the translated strings found in clone :)
paulirish
approved these changes
Aug 1, 2018
paulirish
force-pushed
the
i18n_renderer_numbers_locale
branch
from
51395a6
to
6728655
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another piece of #5719, localize the numbers according to the locale specified in the LHR
note the 0,3 s