Internationalization of Lighthouse (Phase 1)

[paulirish]

Through a series of PRs and CLs we're much closer to having Lighthouse i18n-ready than before. Some relevant PRs: #5644, #5655, #5713, #5716, #5718

Known remaining work:

• Dump workflow established. xtb dump -> json -> LH core locale files @paulirish
• Add [ICU Syntax] to all descriptions of fields that use icu message syntax. it can start or end with this label string @paulirish core(i18n): add [ICU Syntax] label to relevant message descriptions #5736
• Pass locale to toLocaleString calls in renderer @patrickhulce @brendankenny report(i18n): use LHR locale for toLocaleString #5734
• Figure out locale fallback. (PSI user with locale pt-PT should get pt, not en-US). Where does this happen? @brendankenny core(i18n): add locale fallbacks when language not supported #5746
• Add descriptions to ALL strings (enabled by core(i18n): support descriptions #5718) @patrickhulce @brendankenny @paulirish
• Refactor renderer use of Util.UIStrings in reportRenderer. Instead of setup/breakdown, use a str() method which chooses between provided renderer strings and fallbacks defined in Util.UIStrings.
• (psi) Expose a Util.prepareLHR() method
• fix icumessageinstanceid string in extension category setup
• Roll TC locales back into gh repo core(i18n): add localized messages for 52 locales #5780
• Address remaining english strings in report:
  • CRC template @patrickhulce @paulirish report(i18n): localize CRC renderer strings #5730
  • UserTiming has 4 strings core(i18n): add strings for user timing entries table #5806
  • runtime settings PUNTED
  • export dropdown (low pri) PUNTED
• Text-expansion (de) UI review
• Use placeholders for our use of origin? See https://goto.google.com/gnjrf
  • Confirm non-translated strings (eg. "origin", product names) are as expected. URL can be translated.
• address TC locale fallback story
• figure out Node's ICU support on Travis/Appveyor (Number.toLocaleString appears to always use 'en-US' - Travis failure)
  • presumably the node install is system-icu or small-icu
  • can we resolve with an NVM flag or travis config?
• temporarily exclude locale json files from ext build

ship l10n'd lighthouse to extension/devtools

• localize error messages. Localize the error messages #6441
• RTL layout @paulirish
• lang attribute report(i18n): set lang attribute according to locale #5805
• include locale json files in build

Plz add anything else here

[brendankenny]

figure out Node's ICU support on Travis/Appveyor (Number.toLocaleString appears to always use 'en-US')

can we resolve with an NVM flag or travis config?

looks like yes we can, but have to pass --with-intl=full-icu to nvm manually instead of relying on travis's built-in version selection.

See travis-ci/travis-ci#9422 (comment) and nvm-sh/nvm#1719.

I haven't looked into appveyor yet.

[thom4parisot]

Newest release of nvm should address #5719 (comment)

[paulirish]

We call this one done, folks. 👍 👍 👍 👍 👍

#7238 "Internationalization of Lighthouse (Phase 2)" paints the road ahead.