core(i18n): roll latest TC messages #5802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
Aug 7, 2018
lighthouse-core/lib/locales/index.js
Outdated
| 'zh': require('./zh-CN.json'), | ||
| 'zh-CN': require('./zh-CN.json'), | ||
| 'zh': require('./zh.json'), | ||
| 'zh-CN': require('./zh.json'), // Alias of 'zh' |
There was a problem hiding this comment.
do you want to include this since it'll fall back to zh anyways?
lighthouse-core/lib/locales/index.js
Outdated
|
|
||
| 'gsw': require('./de.json'), // swiss german. identical (for our purposes) to 'de' | ||
| // TODO: en-GB has just ~10 messages that are different from en-US. We should only ship those. | ||
| 'en-AU': require('./en-GB.json'), // Don't fallback to en (which -> en-US) |
There was a problem hiding this comment.
just use Alias of 'en-GB' for all these as for entries below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed up the upstream BUILD file to match, so it doesn't output files that are duplicates.
iwaliased to hebrewinaliased to 'id' (indonesian)sris cyrillic)(I apologize in advance if any of this offends someone. Please let me know if any of these mappings are incorrect.)