Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(report): fix cursor behaviour #5977

Merged
merged 3 commits into from
Sep 10, 2018
Merged

core(report): fix cursor behaviour #5977

merged 3 commits into from
Sep 10, 2018

Conversation

midzer
Copy link
Contributor

@midzer midzer commented Sep 6, 2018

Summary

Right now there is some inconsistency in our report on (mainly <detail>) elements who can be collapsed. Mouse cursor: pointer should be set in CSS to indicate whether element is clickable

A minor bugfix. More testing is highly appreciated as I cannot be sure to cover every relevant element

Improve general user experience

Related Issues/PRs

#5958

@midzer midzer changed the title core(report): fix cursor pointer behaviour core(report): fix cursor behaviour Sep 6, 2018
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm I think we probably don't have to set and unset so much...

what about using pointer on like... .lh-root details > summary ?

@midzer
Copy link
Contributor Author

midzer commented Sep 10, 2018

@paulirish wow. your proposed selector works perfectly 👍
updating in a minute

@paulirish paulirish merged commit 6eaf51b into GoogleChrome:master Sep 10, 2018
@midzer midzer deleted the fixCursorBehaviour branch September 10, 2018 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants