core(driver): add check to make sure Runtime.evaluate result exists #6089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exterkamp
changed the title
exterkamp
changed the title
exterkamp
changed the title
paulirish
requested changes
Sep 22, 2018
lighthouse-core/gather/driver.js
Outdated
| return reject(new Error('an unexpected driver error occurred')); | ||
| } | ||
|
|
||
| // Protocol should always return a 'result' object, but it is sometimes undefined |
lighthouse-core/gather/driver.js
Outdated
| reject(new Error('an unexpected driver error occurred')); | ||
| } if (value && value.__failedInBrowser) { | ||
| reject(Object.assign(new Error(), value)); | ||
| return reject(new Error('an unexpected driver error occurred')); |
There was a problem hiding this comment.
let's change this text. how about this?
`Evaluation exception: ${response.exceptionDetails.text}`
lighthouse-core/gather/driver.js
Outdated
| // Protocol should always return a 'result' object, but it is sometimes undefined | ||
| // see https://github.com/GoogleChrome/lighthouse/issues/6026 | ||
| if (response.result === undefined) { | ||
| return reject(new Error('Driver did not sent a result object')); |
There was a problem hiding this comment.
Runtime.evaluate response omits a result
brendankenny
approved these changes
Sep 22, 2018
lighthouse-core/gather/driver.js
Outdated
|
|
||
| // Protocol should always return a 'result' object, but it is sometimes undefined. See #6026. | ||
| if (response.result === undefined) { | ||
| return reject(new Error('Runtime.evaluate response omits a result')); |
There was a problem hiding this comment.
I know @paulirish just said this, but "omits" is weird here. At least "omitted", maybe "did not contain"?
There was a problem hiding this comment.
I also felt like "a result" was confusing, so clarified it is a "result" object that wasn't there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added an undefined check for driver results to catch an undefined result coming back from the Protocol, which shouldn't happen, but we check anyway to catch if it does.
Relevant Protocol
Related Issues/PRs
addresses: #6026