report(psi): remove redundant varience disclaimer #6110
Conversation
| estValuesEl.textContent = Util.UIStrings.varianceDisclaimer; | ||
|
|
||
| // 'Values are estimated and may vary' is used as the category description for PSI | ||
| if (environment !== 'PSI') { |
There was a problem hiding this comment.
Is this being covered by tsc right now? :)
There was a problem hiding this comment.
@patrickhulce whatcha mean
There was a problem hiding this comment.
meaning is the magic string 'PSI' being checked to make sure we're using it correctly vs. psi, typo PS1 etc
|
Would it make more sense to have it removed from the category descriptor so that it is more consistent across environments? |
|
@exterkamp perhaps. but in this case it's a little different. for LS, we have field data at the top and this disclaimer doesnt apply. and then we have the category description that says "hi all this lab data is from lighthouse. it's different data so here's the disclaimer." whereas in typical LH, we dont have a category description right now. but when we add one, it could make sense to move this disclaimer there. @patrickhulce sure yeah. we could but so far we've avoided hiding with CSS and building the DOM how we want to use it. |
Right now, "Values are estimated and may vary" is shown twice in the PSI case.