Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report(psi): remove redundant varience disclaimer #6110

Merged
merged 2 commits into from
Sep 26, 2018
Merged

report(psi): remove redundant varience disclaimer #6110

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83ee6a8
report(psi): remove redundant varience disclaimer
paulirish Sep 26, 2018
375f560
ts on psi env string
paulirish Sep 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lighthouse-core/report/html/renderer/performance-category-renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,13 @@ class PerformanceCategoryRenderer extends CategoryRenderer {
otherMetrics.forEach(item => {
metricsColumn2El.appendChild(this._renderMetric(item));
});
const estValuesEl = this.dom.createChildOf(metricsColumn2El, 'div',
'lh-metrics__disclaimer lh-metrics__disclaimer');
estValuesEl.textContent = Util.UIStrings.varianceDisclaimer;

// 'Values are estimated and may vary' is used as the category description for PSI
if (environment !== 'PSI') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this being covered by tsc right now? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickhulce whatcha mean

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meaning is the magic string 'PSI' being checked to make sure we're using it correctly vs. psi, typo PS1 etc

const estValuesEl = this.dom.createChildOf(metricsColumn2El, 'div',
'lh-metrics__disclaimer lh-metrics__disclaimer');
estValuesEl.textContent = Util.UIStrings.varianceDisclaimer;
}

metricAuditsEl.classList.add('lh-audit-group--metrics');
element.appendChild(metricAuditsEl);
Expand Down