misc: only allow 1 error from each audit/gatherer #6215
Conversation
There was a problem hiding this comment.
I do like this. It's way better than handling manually, since usually the loop these are being generated in is already accumulating some other value as well.
Is there a good way to alter it so it's per-error per-audit? (an additional tag? not sure of the best way) That way we can track if there's more than one type of error in a gatherer
|
also, this makes me wish that we had |
| const tags = opts.tags || {}; | ||
| if (tags.audit) { | ||
| const key = `audit-${tags.audit}-${err.message}`; | ||
| if (sentryExceptionCache.has(key)) return; |
There was a problem hiding this comment.
Just curious: Could 1 exception have both audit and gatherer tags? In which case returning here would not allow the gatherer tags to be analyzed? I don't think so, but wanted to make sure.
There was a problem hiding this comment.
nope, it either happens in an audit, or a gatherer, or neither :)
|
|
||
| if (tags.gatherer) { | ||
| const key = `gatherer-${tags.gatherer}-${err.message}`; | ||
| if (sentryExceptionCache.has(key)) return; |
There was a problem hiding this comment.
Why check has? Can't it just set it and override the old version in the map? Or is that not readable JS? 😕
There was a problem hiding this comment.
if it has the key we want to return and skip the rest of function execution, not just the rest of the block. worth adding a comment since it's confusing already? :)
Summary
WDYT about this @brendankenny ?
Related Issues/PRs
closes #5994