misc(proto): add audit_mode and timings #6363
Conversation
exterkamp
changed the title
proto/lighthouse-result.proto
Outdated
| // Message containing timing information about the LHR | ||
| message Timing { | ||
| // The total time taken by the LHR | ||
| google.protobuf.DoubleValue total = 1; |
There was a problem hiding this comment.
limited to only total for now on purpose, I assume?
There was a problem hiding this comment.
(timing PR isn't landed yet. i got an extension test blowing up because we nuked that try/catch :)
but since it'll be landing soon....
If we excluded it, it'd be the only property we're excluding in LR.
insert 👢 in 😮
And 10 seconds later I'm all pro-excluding from the proto.. :)
proto/lighthouse-result.proto
Outdated
| // Message containing timing information about the LHR | ||
| message Timing { | ||
| // The total time taken by the LHR | ||
| google.protobuf.DoubleValue total = 1; |
There was a problem hiding this comment.
(timing PR isn't landed yet. i got an extension test blowing up because we nuked that try/catch :)
but since it'll be landing soon....
If we excluded it, it'd be the only property we're excluding in LR.
insert 👢 in 😮
And 10 seconds later I'm all pro-excluding from the proto.. :)
Co-Authored-By: exterkamp <shaneexterkamp5@gmail.com>
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
removing period from @brendankenny 's suggestion
Summary
Adds two missing fields to the proto definition.
Related Issues/PRs
fixes: #6362