report(dom-size): right-align the value column #6372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
brendankenny,
patrickhulce and
paulirish
as code owners
paulirish
approved these changes
Oct 24, 2018
There was a problem hiding this comment.
Yeah this works for me. Nicely done.
will need a yarn update:sample-json
@brendankenny was there more to this change that scared us off last time?
paulirish
changed the title
connorjclark
force-pushed
the
issue-6084-right-align
branch
from
a646411
to
3ecc2fe
Compare
connorjclark
commented
Oct 24, 2018
| @@ -460,7 +460,7 @@ | |||
| "text": "Element" | |||
| }, | |||
| { | |||
| "itemType": "text", | |||
| "itemType": "numeric", | |||
There was a problem hiding this comment.
@exterkamp I had to manually edit this one :'(
brendankenny
approved these changes
Oct 24, 2018
There was a problem hiding this comment.
@brendankenny was there more to this change that scared us off last time?
I can't remember, but I think this is fine.
The issue is mostly that it's dumb that this currently has to go through generic render(details) when this case is only ever inside a table. Until we finish making tables sane, though, this is probably the best way to go for now (as long as we don't use it outside tables in the report until we do fix it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6084.