Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(proto): align proto whitespace #6374

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Conversation

exterkamp
Copy link
Member

Summary
Missed tab offset for timing 馃槩

It's really fixed now...

@paulirish paulirish changed the title misc(proto): align proto tabbing misc(proto): align proto whitespace Oct 24, 2018
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Any chance there's a public proto linter we can add? :). This could easily be an annoying issue for whoever is maintaining the proto def for changes that only tangentially touch the file but break formatting

@connorjclark
Copy link
Collaborator

connorjclark commented Oct 24, 2018

Yup, there is this linter, implemented as a protoc plugin. Simpler to use would be this npm package.

@paulirish
Copy link
Member

Any chance there's a public proto linter we can add? :)

right after this PR went up, shane and i tried out the one @hoten linked. unfortunately, it doesnt care about line length. nor indentation.

the google linter actually also doesn't care about indentation either.

But that all said, I def agree there's an opportunity for some stronger tooling here. thx @hoten for filing #6376

@paulirish paulirish merged commit 70ec41c into master Oct 24, 2018
@paulirish paulirish deleted the bug/proto-off-by-space branch October 24, 2018 03:56
@connorjclark
Copy link
Collaborator

Seems this Ruby linter works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants