report: rename clump classes; give classes to all audit groups #6482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Nov 5, 2018
|
|
||
| assert.equal(passedAudits.length, 0); | ||
| assert.equal(failedAudits.length, 12); | ||
|
|
||
| assert.equal(elem.querySelector('.lh-passed-audits-summary'), null); |
There was a problem hiding this comment.
lh-passed-audits-summary hasn't been a thing for a long time, so of course it was null :)
paulirish
approved these changes
Nov 5, 2018
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working on #6395
The PWA category renderer needs to add custom icons to its groups (like the performance renderer does), but to do so without creating each group itself or grossly reaching into things, this PR sets it up by adding a class name to each group based on the group's id in the config (
.lh-audit-group--${groupId}, modelled after the existinglh-audit-group--metrics,lh-audit-group--opportunities, etc).To not collide with anything, the clump names need to move off a mishmash of class names (
lh-failed-audits,lh-audit-group--manual, etc). So we'll just double down on "clump" for those :)This PR also removes
lh-audit-group--unadornedsince "unadorned" is not a group name and it's somewhat ambiguous what should fall into that class, but that leaves a bit of a mess with::beforecontent and margins. I believe I have that all straightened out now. Previously the "unadorned" case took things away from the styling of clumps and important groups, now it's more the default style and clumps and important groups add to it.