Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA category refactor tracking issue #6395

Closed
31 tasks done
brendankenny opened this issue Oct 25, 2018 · 19 comments
Closed
31 tasks done

PWA category refactor tracking issue #6395

brendankenny opened this issue Oct 25, 2018 · 19 comments
Assignees
Labels

Comments

@brendankenny
Copy link
Member

brendankenny commented Oct 25, 2018

New groupings:

Fast and Reliable

Installable

PWA Optimized

Manual

  • Page transitions don't feel like they block on the network
  • Site works cross-browser
  • Each page has a URL

Next:

Lighthouse v5

  • ⁅ ⁆ Figure out LHR/scoring story
@hwikyounglee
Copy link

Suggesting 'Optimized' in the place of 'Engaging'
Thanks @brendankenny !

@hwikyounglee
Copy link

And we landed on "PWA Optimized"
cc: @kusler @paulirish 💅

@egsweeny
Copy link
Contributor

egsweeny commented Nov 6, 2018

What about 'Enhancements'?

@egsweeny
Copy link
Contributor

egsweeny commented Nov 6, 2018

Refinements
Further Improvements
?

@hwikyounglee
Copy link

I'm hoping the word is useful when we say something like, "Making it Reliable and Fast, Installable, and PWA Optimized can help your app provide a great app experience."

@egsweeny
Copy link
Contributor

egsweeny commented Nov 6, 2018

Hmm... But isn't it a little redundant because it's already in the PWA section?

@patrickhulce
Copy link
Collaborator

FWIW, here are some of my thoughts. That section is a grab-bag of things that make the app feel not terrible. They're baseline things that make it more like how a professional, well-put-together, native-like app would feel. These are the words that come to my mind when I think about the audits in there

Usable
Presentable
Cohesive
Snazzy

@hwikyounglee
Copy link

hwikyounglee commented Nov 6, 2018

Hoping it to feel more action-oriented i.e. [the word] is done to the app by the developer.
Something about 'Polished' didn't sound right to me, it's probably because it describes both action and perception by others. I still feel 'Optimized' is a nice balance. If it causes a confusion, we can continue to iterate on it.

Would 'Refined' work?
To be clear, my preference is 'Optimized' > 'PWA Optimized' > 'Refined'

@brendankenny
Copy link
Member Author

I went with "PWA Optimized" for now as a compromise, but I'll throw my vote in for "Polished" as well :)

If it causes a confusion, we can continue to iterate on it.

We'll need to do this fairly quickly, since we'll want to have it locked down by 4.0 (so, this week :).

We can have a different group name from group id and so be able to change what's displayed in the future, but it would be nice to have them not too far apart.

@exterkamp
Copy link
Member

From CR in #6486:

I feel like a fill of #ffffff is too low contrast/I don't like the color combo, and #5e6268 is too dark with these very filled in icons. I prefer a lighter grey like #a3a7ae or something like that. This is all semantics tho.

Top is current, middle matches all other icon fill colors, bottom is a softer grey.
image

@hwikyounglee
Copy link

  • Category name: "PWA Optimized" SGTM
  • Icon color: we can try #cfd8dc for the BG color. I would keep the icon shape in white. If it's filled with a color, it looks like it's already fulfilled.

@patrickhulce
Copy link
Collaborator

Ooooooo "Polished" is exactly what I was searching for :)

@hwikyounglee
Copy link

"Polished" seems to have a notion of perception by others (i.e. feels judged a bit).

@brendankenny
Copy link
Member Author

@hwikyounglee commented in #6526

I think we can use a few more pixels above the sub group title (to make the total pixel 24px).

image

Agreed, the only issue is the other categories and if they should have similar spacing. I know it was requested to keep the perf section more compact, for instance, but it feels weird for them to have different spacing around their group icons

screen shot 2018-11-15 at 18 19 34

@brendankenny
Copy link
Member Author

@paulirish commented

I'm wondering if we should also clarify the state in a tooltip.

We could do with a full lh-tooltip and bulleted list, but here's a minimal [title] example:
image

@hwikyounglee
Copy link

Alternative idea:
Fast and reliable: 3/3, Installable: 3/3, PWA Optimized: 4/6

@hwikyounglee
Copy link

re: vertical spacing

+1 to using the same spacing for other categories. Vertical spacing could help with seeing a long list with visual grouping.

@brendankenny
Copy link
Member Author

re: vertical spacing

ok, great. I'll add it to the list 👍

@brendankenny
Copy link
Member Author

💥 💥 💥 💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants
@brendankenny @patrickhulce @exterkamp @hwikyounglee @egsweeny and others