report(pwa): give badges to groups with all passing audits #6504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Nov 7, 2018
| @@ -16,9 +16,6 @@ const DOM = require('../../../../report/html/renderer/dom.js'); | |||
| const DetailsRenderer = require('../../../../report/html/renderer/details-renderer.js'); | |||
| const ReportUIFeatures = require('../../../../report/html/renderer/report-ui-features.js'); | |||
| const CategoryRenderer = require('../../../../report/html/renderer/category-renderer.js'); | |||
| // lazy loaded because they depend on CategoryRenderer to be available globally | |||
There was a problem hiding this comment.
these last two files cleaned up based on @patrickhulce feedback in #6486 (comment)
patrickhulce
approved these changes
Nov 8, 2018
| assert.ok(targetGroupId); | ||
| const targetAuditRefs = auditRefs.filter(ref => ref.group === targetGroupId); | ||
|
|
||
| // Try every permutation of audit scoring. |
There was a problem hiding this comment.
seems a bit excessive 😆 but respect 🙇
There was a problem hiding this comment.
seems a bit excessive
haha, yes. I was hemming and hawing on which cases to include and said "screw it, we'll do all of them" :)
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #6395
When all the audits in a PWA category group are passing, the icon goes from grayscale to color to indicate its badge (score gauge is still unstyled).