core: add group support for plugins #7304
Conversation
Update tests to ensure groups are added properly.
jburger424
requested review from
brendankenny and
patrickhulce
as code owners
jburger424
changed the title
jburger424
changed the title
There was a problem hiding this comment.
Thanks for the contribution @jburger424!! mind posting a screenshot with the motivating example? :)
Apologies if you may have already communicated this internally, and I'm just out of the loop.
The motivating example for this is our plugin Ad Speed Insights. |
There was a problem hiding this comment.
LGTM % few nits
I'll defer to @brendankenny, the plugin master, though for approval.
Minor changes in response to PR comments.
| @@ -84,6 +93,7 @@ describe('ConfigPlugin', () => { | |||
| categories: { | |||
| 'lighthouse-plugin-evil': evilCategory, | |||
| }, | |||
| groups: undefined, | |||
There was a problem hiding this comment.
do these two additions add anything to the test? My brain may be just foggy today and I'm missing it :)
There was a problem hiding this comment.
Tests were failing without this because the undefined group object is not yet stripped at this point.
| audits: [ | ||
| {path: 'redirects'}, | ||
| {path: 'user-timings'}, | ||
| ], | ||
| category: { | ||
| title: 'Simple', | ||
| auditRefs: [], | ||
| auditRefs: [ | ||
| {id: 'redirects', weight: 1, group: 'new-group'}, |
There was a problem hiding this comment.
oh, ha, there weren't any audit refs to add a group to before. Sorry I missed that :)
Summary
Allow for plugin to add custom groups and assign custom to plugin auditRefs.
Modify tests to verify groups added and assigned properly.
Related Issues/PRs
#6959
#6070