core(main-thread-tasks): use toplevel tasks in main thread audit #7711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
requested review from
brendankenny,
exterkamp and
paulirish
as code owners
brendankenny
approved these changes
Mar 27, 2019
| @@ -32,18 +32,16 @@ class MainThreadTasks extends Audit { | |||
| const tasks = await MainThreadTasksComputed.request(trace, context); | |||
|
|
|||
| const results = tasks | |||
| .filter(task => task.duration > 5 && task.parent) | |||
| .filter(task => task.duration > 5 && !task.parent) | |||
There was a problem hiding this comment.
maybe add a comment that top level === no parent here? Easy to miss the point of the filter though it's obvious once you realize :)
There was a problem hiding this comment.
yeah good call, I mean I missed it the first time around 😆
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Typo in the
main-thread-tasksaudit, I didn't get around to surfacing this yet, so it shouldn't have hurt anything. I think I was originally going for first inner child of toplevel task so we'd actually have a type, but then again I wasn't using the results yet, so 🤷♂️Related Issues/PRs
#7700