Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(smoke): remove trivial uses of rawValue from expectations #7780

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

connorjclark
Copy link
Collaborator

These were the simple ones - the ones that an equivalent assertion on score was possible. One that seemed to not assert anything really.

Related Issues/PRs

#6199

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Incrementally killing rawValue!

@paulirish paulirish merged commit 0ad3440 into master Mar 29, 2019
@paulirish paulirish deleted the smoketest-less-rawvalue branch March 29, 2019 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants