Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension breaks chromestatus #72

Closed
npm1 opened this issue Jun 24, 2020 · 3 comments
Closed

Extension breaks chromestatus #72

npm1 opened this issue Jun 24, 2020 · 3 comments
Assignees

Comments

@npm1
Copy link

npm1 commented Jun 24, 2020

Describe the bug
When the extension is enabled and I am logged in on https://www.chromestatus.com/feature/5167290693713920, I cannot see the 'star', 'file a bug', or 'edit' buttons. Once I disabled the extension and refresh, I am able to see those buttons.

Version:

  • OS w/ version: MacOS Catalina
  • Browser w/ version Chrome 83
@addyosmani
Copy link
Member

addyosmani commented Jun 26, 2020

@npm1 Thank you for filing this issue. I've attempted to repro this issue using M83 and M85, both with the current stable version of the extension and the version in master. It appears ChromeStatus is rendering as one would expect. Please see screenshots below.

Would it be possible to share if the version you used was installed from Chrome Web Store? https://chrome.google.com/webstore/detail/web-vitals/ahfhijdlegdabablpippeagghigmibma?hl=en. There definitely were issues with style scoping leaks causing issues like this in earlier, alpha versions of the extension. We addressed these before pushing to the web store (or so we thought).

M83 (stable version of extension from store):

Screen Shot 2020-06-25 at 5 58 58 PM

M85 (stable version of extension):

Screen Shot 2020-06-25 at 5 57 25 PM

M85 (master/bleeding edge version of extension)

Screen Shot 2020-06-25 at 5 57 57 PM

Screen Shot 2020-06-25 at 6 03 14 PM

@npm1
Copy link
Author

npm1 commented Jun 26, 2020

Looks like I was using version 0.1.0. I removed that and installed the ones you linked above and this is no longer an issue. Thanks!

@npm1 npm1 closed this as completed Jun 26, 2020
@addyosmani
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants